Allow $0 as valid card limit when editing Expensify Card by MelvinBot · Pull Request #90540 · Expensify/App

MelvinBot · 2026-05-13T16:47:21Z

Explanation of Change

Two fixes for Expensify Card management when cards have a $0 limit set from OldDot:

1. filterAllInactiveCards in CardUtils.ts — When includeDeactivated is true (workspace card list), show all suspended cards so admins can view and edit them, not just zero-limit ones. Also removes the code path that returned STATE_DEACTIVATED cards, since the server rejects limit updates on deactivated cards with a 403 error — those cards should never appear in the editable card list.

2. Validator in DynamicExpensifyCardLimitPage.tsx — Changed !Number(values.limit) to Number.isNaN(Number(values.limit)) so that $0 is accepted as a valid limit. A suspended card with a current limit of $0 still needs to load the edit form without tripping "invalid amount".

Fixed Issues

$ #90487

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

Verify that no errors appear in the JS console

Navigate to Workspace > Expensify Card
Assign or issue virtual card to any member
Switch to Expensify Classic (OD), and set the previous assigned Expensify Card's limit to $0
Switch back to ND and navigate to Expensify Card. The card with limit $0 appears in the list
Open it and try to edit the Card limit
Confirm User can navigate to edit limit, edit name, and edit limit type without errors
Verify that deactivated cards (STATE_DEACTIVATED) do NOT appear in the workspace card list
Verify that suspended cards (STATE_SUSPENDED) DO appear and are editable

Offline tests

N/A — validation is purely client-side with no network dependency.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The validation in DynamicExpensifyCardLimitPage used !Number(values.limit) to check for invalid amounts. Since Number('0') is 0 and !0 is true, a $0 limit was always rejected as invalid. This prevented editing cards whose limit was set to $0 in Expensify Classic. Changed the check to Number.isNaN(Number(values.limit)) which correctly allows 0 while still rejecting non-numeric input. Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>

codecov · 2026-05-13T16:58:00Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/CardUtils.ts	`81.84% <100.00%> (-0.08%)`	⬇️
...ce/expensifyCard/DynamicExpensifyCardLimitPage.tsx	`0.00% <0.00%> (ø)`
... and 12 files with indirect coverage changes

github-actions · 2026-05-14T15:13:01Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

melvin-bot · 2026-05-14T15:39:17Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane · 2026-05-16T12:34:59Z

@grgia The issue is still reproducible on my end.

Steps To reproduce:

Navigate to Expensify Card
Click on the card with limit $0
Try to edit the Card limit

Screen.Recording.2026-05-16.at.18.07.36.mov

sobitneupane · 2026-05-16T13:05:12Z

This is for another card. When I try to edit limit and set it to non-zero value, it disappears from the list. I suspect this is because we only show inactive cards with a $0 limit.

Screen.Recording.2026-05-16.at.18.40.53.mov

sobitneupane · 2026-05-16T17:13:18Z

Here are my findings:

function filterAllInactiveCards(cards: CardList | undefined, includeDeactivated = false) {
    if (!cards) {
        return {};
    }

    const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED]);
    return filterObject(cards, (_key, card) => {
        const isAdminZeroedExpensifyCard = isExpensifyCard(card) && isCardWithCustomZeroLimit(card);
        if (card.state === CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED) {
            return !!card.nameValuePairs?.frozen || (includeDeactivated && isAdminZeroedExpensifyCard);
        }
        if (card.state === CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED) {
            return includeDeactivated && isAdminZeroedExpensifyCard;
        }
        return !closedStates.has(card.state);
    });
}

The "Not found page" issue happens because we filter out the deactivated cards with a non-zero card limit. So, when the limit is updated to a non-zero value, the card disappears from the list.
The server doesn't allow editing the card limit for deactivated cards (unlike suspended cards, where this is allowed) based on what I observed. As a result, when the server responds and resets the limit back to initial value(zero in this case), the card becomes visible again.
IMO, we should allow suspended cards with a non-zero limit as well (which aligns with OD behavior). This would parially resolve the issue.
IMO, we should not show deactivated cards at all. Allowing deactivated cards (even with non-zero limits) would not match OD behavior based on what I observed.

Proposed change:

Allow suspended cards regardless of limit when includeDeactivated is true.
Stop allowing deactivated cards.

function filterAllInactiveCards(cards: CardList | undefined, includeDeactivated = false) {
    if (!cards) {
        return {};
    }

    const closedStates = new Set<number>([CONST.EXPENSIFY_CARD.STATE.CLOSED, CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED]);
    return filterObject(cards, (_key, card) => {
        const isAdminZeroedExpensifyCard = isExpensifyCard(card) && isCardWithCustomZeroLimit(card);
        if (card.state === CONST.EXPENSIFY_CARD.STATE.STATE_SUSPENDED) {
-            return !!card.nameValuePairs?.frozen || (includeDeactivated && isAdminZeroedExpensifyCard);
+           return !!card.nameValuePairs?.frozen || includeDeactivated
        }
-        if (card.state === CONST.EXPENSIFY_CARD.STATE.STATE_DEACTIVATED) {
-           return includeDeactivated && isAdminZeroedExpensifyCard;
-       }
        return !closedStates.has(card.state);
    });
}

…activated cards When includeDeactivated is true, show all suspended cards (not just zero-limit ones) so admins can view and edit them. Remove the deactivated card path entirely since the server rejects limit updates on STATE_DEACTIVATED cards with a 403 error. Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>

melvin-bot · 2026-05-18T10:34:39Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-05-18T10:36:05Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

MelvinBot · 2026-05-18T10:36:35Z

Updated the PR with both changes:

filterAllInactiveCards — When includeDeactivated is true, all suspended cards are now shown (not just zero-limit ones). The STATE_DEACTIVATED code path is removed entirely since the server rejects limit updates on those cards with a 403.
JSDoc on filterInactiveCardsForWorkspace — Updated to say "keeps all suspended cards" instead of "keeps issued deactivated cards and zero-limit suspended cards".
Validator change in DynamicExpensifyCardLimitPage.tsx — kept as-is from the original commit.

isCardWithCustomZeroLimit references at lines 1615 and 1664 left untouched per instructions. Ran prettier (no changes needed) and typecheck-tsgo (no new errors). PR description updated to describe both changes.

github-actions · 2026-05-18T10:40:16Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #90540.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://90540.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

…rds behavior Tests were asserting old behavior where only admin-zeroed suspended cards were kept. Updated to reflect the new logic: all suspended cards are kept when includeDeactivated is true, and STATE_DEACTIVATED cards are always excluded since the server rejects limit updates on them. Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>

MelvinBot · 2026-05-18T10:46:56Z

Fixed the failing test (job 4) check: the CardUtilsTest.ts assertions for filterAllInactiveCards and filterInactiveCardsForWorkspace were still expecting the old behavior. Updated them to match the new logic where all suspended cards are kept when includeDeactivated is true, and STATE_DEACTIVATED cards are always excluded.

MelvinBot · 2026-05-18T11:08:39Z

The failing perf-tests check is unrelated to this PR's changes.

Failure: [ReportActionCompose] should render Composer with text input interactions — render count exceeded the allowed deviation of 0 (current difference: 1).

Why it's unrelated: This PR only modifies CardUtils.ts, DynamicExpensifyCardLimitPage.tsx, and CardUtilsTest.ts — none of which touch ReportActionCompose or the Composer component. This is a known flaky Reassure perf test. Re-running the workflow should resolve it.

grgia · 2026-05-18T14:53:40Z

@MelvinBot merge main

…lidation Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>

MelvinBot · 2026-05-18T14:59:33Z

Merged main into this branch successfully.

grgia · 2026-05-18T16:20:34Z

@sobitneupane latest branch works on my card test- can you check with yours?

grgia · 2026-05-18T16:20:45Z

If it still doesn't feel free to stop there

MelvinBot assigned grgia May 13, 2026

MelvinBot requested a review from a team May 13, 2026 16:47

MelvinBot mentioned this pull request May 13, 2026

Expensify Card - Error when try to edit the limit of the first assigned card #90487

Open

7 tasks

grgia previously approved these changes May 14, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

grgia marked this pull request as ready for review May 14, 2026 15:39

grgia requested a review from a team as a code owner May 14, 2026 15:39

melvin-bot Bot requested review from flaviadefaria and sobitneupane and removed request for a team May 14, 2026 15:39

melvin-bot Bot removed the request for review from a team May 14, 2026 15:39

This comment was marked as resolved.

Sign in to view

MelvinBot dismissed grgia’s stale review via b6bd285 May 18, 2026 10:34

MelvinBot requested a review from a team as a code owner May 18, 2026 10:34

melvin-bot Bot requested review from grgia and removed request for a team May 18, 2026 10:34

Merge remote-tracking branch 'origin/main' into claude-fixZeroLimitVa…

203fc76

…lidation Co-authored-by: Georgia Monahan <grgia@users.noreply.github.com>

Conversation

MelvinBot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

This comment has been minimized.

melvin-bot Bot commented May 14, 2026

Uh oh!

sobitneupane commented May 16, 2026

Uh oh!

sobitneupane commented May 16, 2026

Uh oh!

sobitneupane commented May 16, 2026

Uh oh!

This comment was marked as resolved.

melvin-bot Bot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

MelvinBot commented May 18, 2026

Uh oh!

github-actions Bot commented May 18, 2026

Uh oh!

MelvinBot commented May 18, 2026

Uh oh!

MelvinBot commented May 18, 2026

Uh oh!

grgia commented May 18, 2026

Uh oh!

MelvinBot commented May 18, 2026

Uh oh!

grgia commented May 18, 2026

Uh oh!

grgia commented May 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MelvinBot commented May 13, 2026 •

edited

Loading

codecov Bot commented May 13, 2026 •

edited by github-actions Bot

Loading